Re: Does "verbose" Need to be Reserved?

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: david(at)kineticode(dot)com ("David E(dot) Wheeler"), PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Does "verbose" Need to be Reserved?
Date: 2009-12-16 20:20:32
Message-ID: 87vdg6oerq.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "David" == "David E Wheeler" <david(at)kineticode(dot)com> writes:

David> Hey All,
David> I was just getting a new version of pgTAP ready for release, and while testing it on HEAD, I got this error:

David> + psql:pgtap.sql:5789: ERROR: syntax error at end of input
David> + LINE 28: IF verbose THEN RETURN NEXT diag(tests[i] ||...
David> + ^

David> I asked on IRC, and Andrew “RhodiumToad” Gierth pointed out
David> that it became a reserved word at some point. I'm fine to
David> rename my variable, but Andew and I were wondering if it's
David> really necessary for "verbose" to be reserved, since it's not
David> in the spec.

Looking at it more closely, this is likely to be fallout from the
plpgsql lexer/parser changes; it probably worked before only because
plpgsql was doing its own thing rather than using the main lexer.

VERBOSE has been reserved all along in order to distinguish
'vacuum verbose;' from 'vacuum tablename;' and so on; but it's still an
interesting pitfall for plpgsql users.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2009-12-16 20:24:36 Re: Range types
Previous Message Martijn van Oosterhout 2009-12-16 20:07:39 Re: Range types