Re: Review of patch renaming constraints

Hi,

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On tor, 2012-01-12 at 22:43 -0600, Joshua Berkus wrote:
>> Most normal uses of alter table ... rename constraint ... worked
>> normally. However, the patch does not deal correctly with constraints
>> which are not inherited, such as primary key constraints:
>
> New patch which works around that issue.

I've been reviewing this new patch and it seems ready for commiter for
me: the code indeed looks like it's always been there, the corner cases
are covered in the added regression tests, including the one Josh ran
into problem with in the previous round of testing.

The regression test covering made me lazy enough not to retry the patch
here, I trust Peter on testing his own work here :)

I'll update my command trigger patch as soon as this one makes it in.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support