Re: BUG #14228: replication slot catalog_xmin not cleared on slot reuse

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14228: replication slot catalog_xmin not cleared on slot reuse
Date: 2016-07-06 03:56:31
Message-ID: 87vb0ja0b5.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

>>>>> "Michael" == Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:

>> When creating a physical replication slot, the catalog_xmin field of
>> the new slot is not initialized. If the slot storage had previously
>> been used for a logical slot, the old catalog_xmin will remain in
>> place and interfere with vacuum.

Michael> Good catch! The same applies to confirmed_flush_lsn, which is
Michael> used only by logical decoding and should remain as NULL for
Michael> physical slots. So I propose the patch attached to address
Michael> both problems.

What about slot->effective_catalog_xmin ?

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2016-07-06 04:07:36 Re: BUG #14228: replication slot catalog_xmin not cleared on slot reuse
Previous Message Michael Paquier 2016-07-06 02:08:35 Re: BUG #14228: replication slot catalog_xmin not cleared on slot reuse