Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding.

From: Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding.
Date: 2018-06-21 08:31:17
Message-ID: 87vaacpmlm.fsf@ars-thinkpad
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Thank you for your time.

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:

> On 2018-Jun-11, Antonin Houska wrote:
>> One comment about the coding: since you introduce a new transaction list and
>> it's sorted by LSN, I think you should make the function AssertTXNLsnOrder()
>> more generic and use it to check the by_base_snapshot_lsn list too. For
>> example call it after the list insertion and deletion in
>> ReorderBufferPassBaseSnapshot().

Ok, probably this makes sense. Updated patch is attached.

>> Also I think it makes no harm if you split the diff into two, although both
>> fixes use the by_base_snapshot_lsn field.
> Please don't.

Yeah, I don't think we should bother with that.

Arseny Sher
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0001-Fix-slot-s-xmin-advancement-and-subxact-s-lost-snaps.patch text/x-diff 26.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-06-21 09:13:42 Making "COPY partitioned_table FROM" faster
Previous Message Heikki Linnakangas 2018-06-21 08:00:34 Re: Push down Aggregates below joins