From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Chapman Flack <chap(at)anastigmatix(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: *_to_xml() should copy SPI_processed/SPI_tuptable |
Date: | 2018-09-06 20:47:40 |
Message-ID: | 87va7is6a8.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
Tom> Also, in further service of providing insulation between SPI
Tom> nesting levels, I thought it'd be a good idea for SPI_connect() to
Tom> reset the globals to zero/NULL after saving them. This ensures
Tom> that a nesting level can't accidentally be affected by the state
Tom> of an outer level. It's barely possible that there's somebody out
Tom> there who's *intentionally* accessing state from a calling SPI
Tom> level, but that seems like it'd be pretty dangerous programming
Tom> practice. Still, maybe there's an argument for omitting that hunk
Tom> in released branches.
Tom> Comments?
+1 to backpatching it all, including the initialization in SPI_connect.
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-09-06 20:50:23 | Commit fest 2018-09 |
Previous Message | Tom Lane | 2018-09-06 20:40:00 | Re: *_to_xml() should copy SPI_processed/SPI_tuptable |