| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Robins Tharakan <tharakan(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix tab completion in v18 for ALTER DATABASE/USER/ROLE ... RESET |
| Date: | 2025-07-31 14:21:33 |
| Message-ID: | 87v7n8h24y.fsf@wibble.ilmari.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(at)vondra(dot)me> writes:
> On 7/30/25 12:17, Dagfinn Ilmari Mannsåker wrote:
>>
>> ...
>>
>>> @@ -5015,7 +5021,8 @@ match_previous_words(int pattern_id,
>>> /* Complete with a variable name */
>>> else if (TailMatches("SET|RESET") &&
>>> !TailMatches("UPDATE", MatchAny, "SET") &&
>>> - !TailMatches("ALTER", "DATABASE", MatchAny, "RESET"))
>>> + !TailMatches("ALTER", "DATABASE", MatchAny, "RESET") &&
>>> + !TailMatches("ALTER", "USER|ROLE", MatchAny, "RESET"))
>>> COMPLETE_WITH_QUERY_VERBATIM_PLUS(Query_for_list_of_set_vars,
>>> "CONSTRAINTS",
>>> "TRANSACTION",
>>
>> Instead of adding another !TailMatches() call, why not just change
>> "DATABASE" to "DATABASE|ROLE|USER"?
>
> It seemed to me separate calls would be easier to understand, but I see
> combine it like this in many other places, so done that way ...
>
> Pushed.
Thanks!
> Thanks for the fixes!
>
> regards
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-07-31 14:27:37 | Re: Making type Datum be 8 bytes everywhere |
| Previous Message | Andrei Lepikhov | 2025-07-31 14:20:04 | Re: MergeAppend could consider sorting cheapest child path |