Re: Improve tab completion for various SET/RESET forms

Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> writes:

> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>
>> On 09.06.25 22:27, Dagfinn Ilmari Mannsåker wrote:
>>> I noticed that psql tab-completes every possible session-settable
>>> variable after RESET, not just the ones that have actually been set in
>>> the current session. However, as I was fixing that I noticed several
>>> other deficiencies around other forms of SET/RESET. So, here's the
>>> resulting yak stack.
>>
>> These technical changes seem fine, but I haven't looked in detail. But
>> I want to say that I don't like this proposed behavior change at all.
>
> This is not the first case of behaviour like this: there's precedence
> for it for ALTER DATABASE ... RESET and ALTER ROLE ... RESET (but that
> was buggy and is fixed by the first patch in the series): they only
> complete variables that are actually set on the relevant entity. See the
> thread at
> https://postgr.es/m/CAEP4nAzqiT6VbVC5r3nq5byLTnPzjniVGzEMpYcnAHQyNzEuaw%40mail.gmail.com

I just noticed that in addition to ALTER ROLE ... RESET being buggy, the
ALTER DATABASE ... RESET query doesn't schema-qualify the unnest() call.
Here's an updated patch series that fixes that too. The first two are
bug fixes to features new in 18 and should IMO be committed before
that's released. The rest can wait for 19.

- ilmari