Re: Proposed patch - psql wraps at window width

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgresql(dot)org>, "Aidan Van Dyk" <aidan(at)highrise(dot)ca>, "Brendan Jurd" <direvus(at)gmail(dot)com>, "Bryce Nesbitt" <bryce2(at)obviously(dot)com>, <heikki(at)enterprisedb(dot)com>
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-25 05:04:38
Message-ID: 87skxa5xuh.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
>> "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> writes:
>>> On what platforms does ioctl() fail?
>
>> On ssh for example.
>
> That'd certainly be a showstopper if true, but it seems to be okay for
> me. ssh'ing from an xterm window, and running psql on the remote side,
> I can see with gdb that ioctl(TIOCGWINSZ) succeeds and gives a result
> that correctly tracks window resizes --- indeed there are several bits
> of psql that I'd never have committed if they didn't work in this
> environment, because it's been my everyday work environment for years.

Hum. It appears you're right. I did run a test earlier with ssh and strace
where I saw an error from the ioctl.

I have a sneaking suspicion I ran it within my usual emacs shell session
without realizing.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's RemoteDBA services!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2008-04-25 07:03:24 Re: MERGE Specification
Previous Message Joshua D. Drake 2008-04-25 04:08:15 Re: Proposed patch - psql wraps at window width

Browse pgsql-patches by date

  From Date Subject
Next Message Albe Laurenz 2008-04-25 07:00:59 Re: Improve shutdown during online backup, take 4
Previous Message Tom Lane 2008-04-24 22:38:11 Re: Proposed patch - psql wraps at window width