Re: Verbosity of Function Return Type Checks

From: Volkan YAZICI <yazicivo(at)ttmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Verbosity of Function Return Type Checks
Date: 2008-08-09 10:13:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

[Please ignore the previous reply.]

On Fri, 8 Aug 2008, Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I think this is a good idea, but the new error messages need more work.
> Have a look at the message style guidelines please,

Right. Done -- I hope.

> Particularly I think you need to keep the original errmsg() and add the
> new messages as errdetail().

Made callers pass related error message as a string parameter, and
appended required details using errdetail().

> (I notice that there's the slight problem
> that the error messages are different for the different callers.)

Above mentioned change should have addressed this issue too.

> Also, please use context diffs.



Attachment Content-Type Size
plpgsql_validate_tupdesc_compat.diff text/x-diff 5.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Abhijit Menon-Sen 2008-08-09 10:27:42 which statements need bind/describe messages?
Previous Message Volkan YAZICI 2008-08-09 09:54:12 Re: Verbosity of Function Return Type Checks