Re: Verbosity of Function Return Type Checks

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Volkan YAZICI <yazicivo(at)ttmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Verbosity of Function Return Type Checks
Date: 2008-09-04 22:22:23
Message-ID: 20080904222223.GE5786@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Volkan YAZICI wrote:

> Made callers pass related error message as a string parameter, and
> appended required details using errdetail().

Cool, thanks. I had a look and you had some of the expected vs.
returned reversed. This patch should be OK. Amazingly, none of the
regression tests need changing, which is a bit worrisome.

I wasn't able to run the tests in contrib, I don't know why, and I have
to go out now. I'll commit this tomorrow.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment Content-Type Size
plpgsql_validate_tupdesc_compat-2.patch text/x-diff 5.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michelle Caisse 2008-09-04 22:23:43 Re: code coverage patch
Previous Message Alvaro Herrera 2008-09-04 21:20:45 Re: code coverage patch