| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Should contrib modules install .h files? |
| Date: | 2018-07-05 10:45:52 |
| Message-ID: | 87po02m0bh.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> This installs to $(includedir_server)/$(MODULEDIR)/$MODULE/file.h
>> (e.g. include/server/extension/hstore/hstore.h for an actual
>> example), and errors if HEADERS_xxx is defined for anything that's
>> not a module listed in MODULES or MODULE_big.
Tom> I've not studied this patch in any great detail, but the basic
Tom> plan seems sane. However, don't we also need to teach the MSVC
Tom> build system about this?
Yes, also needs to update the pgxs docs.
Looking at the windows build, is there anything needed beyond adding a
check for the HEADERS* vars in Install.pm?
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2018-07-05 11:15:42 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |
| Previous Message | Ashutosh Bapat | 2018-07-05 10:37:04 | Re: TupleTableSlot abstraction |