[PATCH] pg_upgrade: report the reason for failing to open the cluster version file

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file
Date: 2020-02-25 23:14:06
Message-ID: 87pne2w98h.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Hackers,

The other day I was helping someone with pg_upgrade on IRC, and they got
a rather unhelpful error message:

ERROR: could not open version file /path/to/new/cluster/PG_VERSION

It would have saved some minutes of debugging time if that had included
the reason why the open failed, so here's a patch to do so.

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl

Attachment Content-Type Size
0001-pg_upgrade-add-m-to-version-file-open-failure-messag.patch text/x-diff 1007 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-02-25 23:31:26 Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file
Previous Message Andrew Dunstan 2020-02-25 23:12:30 Re: Resolving the python 2 -> python 3 mess