Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)

Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> writes:

> Melanie Plageman <melanieplageman(at)gmail(dot)com> writes:
>
>> + PruneFreezeParams params = {.relation = relation,.buffer = buffer,
>> + .reason = PRUNE_ON_ACCESS,.options = 0,
>> + .vistest = vistest,.cutoffs = NULL
>> + };
>
> I didn't pay much attention to this thread, so I didn't notice this
> until it got committed, but I'd like to lodge an objection to this
> formatting, especially the lack of spaces before the field names. This
> would be much more readable with one struct field per line, i.e.
>
> PruneFreezeParams params = {
> .relation = rel,
> .buffer = buf,
> .reason = PRUNE_VACUUM_SCAN,
> .options = HEAP_PAGE_PRUNE_FREEZE,
> .vistest = vacrel->vistest,
> .cutoffs = &vacrel->cutoffs,
> };

D'oh, my mail client untabified the .buffer line while I was editing it,
that should of course be:

PruneFreezeParams params = {
.relation = rel,
.buffer = buf,
.reason = PRUNE_VACUUM_SCAN,
.options = HEAP_PAGE_PRUNE_FREEZE,
.vistest = vacrel->vistest,
.cutoffs = &vacrel->cutoffs,
};

- ilmari