Re: datachecksums: handle invalid and dropped databases during enable

Hi!

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:

>> Thanks, I've reviewed and tested your patch and intend to push it along with
>> your other earlier patch shortly.
>
> BF member porpoise points out that we seems to have missed a detach in the
> injection points test:
>
> # die: error running SQL: 'psql:<stdin>:1: ERROR: injection point "datachecksumsworker-fake-temptable-wait" already defined'
> # while running 'psql --no-psqlrc --no-align --tuples-only --quiet --dbname
> port=19905 host=/tmp/oQlRAvFxKv dbname='postgres' --file - --variable
> ON_ERROR_STOP=1' with sql 'SELECT
> injection_points_attach('datachecksumsworker-fake-temptable-wait','wait');' at
> /home/buildfarm/pg-buildfarm/builds/HEAD/pgsql/src/test/modules/test_checksums/t/005_injection.pl
> line 92.
> # Looks like your test exited with 29 just after 8.
>
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=porpoise&dt=2026-07-30%2007%3A22%3A50&stg=test_checksums-check

I came here to report exactly the same!

> It only fails when running the extended tests which is why it didn't fail in CI
> or on more BF members (and I clearly forgot to run those tests before pushing).
> Does this seem correct to you?

I've tested your patch and confirm that it fixed the issue

Regards!
--
Jonathan Gonzalez V.
EDB
https://www.enterprisedb.com