[PATCH] Improve spinlock inline assembly for x86.

From: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [PATCH] Improve spinlock inline assembly for x86.
Date: 2016-01-17 11:38:26
Message-ID: 87oack5tcd.fsf@credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I'm currently experimenting with just-in-time compilation using libfirm.
While discussing issues with its developers, it was pointed out to me
that our spinlock inline assembly is less than optimal. Attached is a
patch that addresses this.

,----
| Remove the LOCK prefix from the XCHG instruction. Locking is implicit
| with XCHG and the prefix wastes a byte. Also remove the "cc" register
| from the clobber list as the XCHG instruction does not modify any flags.
|
| Reported by Christoph Mallon.
`----

regards,
Andreas

Attachment Content-Type Size
0001-Improve-spinlock-inline-assembly-for-x86.patch text/x-diff 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2016-01-17 13:00:20 Re: Freeze avoidance of very large table.
Previous Message Fabien COELHO 2016-01-17 08:06:04 Re: Let PostgreSQL's On Schedule checkpoint write buffer smooth spread cycle by tuning IsCheckpointOnSchedule?