Re: A assert failure when initdb with track_commit_timestamp=on

From: Andy Fan <zhihuifan1213(at)163(dot)com>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: 'Michael Paquier' <michael(at)paquier(dot)xyz>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A assert failure when initdb with track_commit_timestamp=on
Date: 2025-07-03 13:31:23
Message-ID: 87o6u19z9w.fsf@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> writes:

> Dear Michael, Fujii-san,
>
>> Ah, indeed, so it was reported a couple of months ago. I am not sure
>> that the argument about all the other GUCs potentially impacted holds
>> much value; we are talking about a specific code path.
>
> Yeah, I did report but sadly it was missed by others :-(. To clarify,
> The current patch looks good to me.

Then I'd thank Michael to watch the maillist closely this time.

I checked the fix suggested by Hayato, I think his patch is better than
me because his patch checks at the startup time while my patch checks at
each time of RecordTransactionCommit. So v3 takes his patch. v3 also
added the testcase suggested by Michael for test coverage, it clearly
proves the bug is fixed now.

--
Best Regards
Andy Fan

Attachment Content-Type Size
v3-0001-Avoid-activating-commit_ts-while-bootstrap.patch text/x-diff 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-07-03 13:37:36 Re: Using failover slots for PG-non_PG logical replication
Previous Message torikoshia 2025-07-03 13:30:34 Re: Improve tab completion for COPY