Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: tgl(at)postgresql(dot)org (Tom Lane)
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin
Date: 2008-09-06 12:06:04
Message-ID: 87myilzdg3.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

tgl(at)postgresql(dot)org (Tom Lane) writes:

> (The materialize protects the sort from having to support mark/restore,
> allowing it to do its final merge pass on-the-fly.) We neglected to teach
> cost_mergejoin about that hack, so it was failing to include the
> materialize's costs in the estimated cost of the mergejoin.

Is that right? The materialize is just doing the same writing that the final
pass of the sort would have been doing. Did we discount the costs for sort for
that skipping writing that final pass when that was done?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's 24x7 Postgres support!

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2008-09-06 14:38:10 Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin
Previous Message Tom Lane 2008-09-06 00:01:25 pgsql: Implement a psql command "\ef" to edit the definition of a

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-09-06 13:32:38 pg_dump/pg_restore items
Previous Message Markus Wanner 2008-09-06 11:34:10 Review Report: propose to include 3 new functions into intarray and intagg