Re: pgsql: Fix "base" snapshot handling in logical decoding

From: Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding
Date: 2018-07-06 07:55:41
Message-ID: 87muv4iyrm.fsf@ars-thinkpad
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers


Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:

> I just don't see it that VACUUM FULL would change the xmin of anything
> to FrozenXid, and in my experiments it doesn't. Did you mean VACUUM
> FREEZE?

Well, docs for VACUUM say:

FREEZE

Selects aggressive “freezing” of tuples. Specifying FREEZE is
equivalent to performing VACUUM with the vacuum_freeze_min_age and
vacuum_freeze_table_age parameters set to zero. Aggressive freezing
is always performed when the table is rewritten, so this option is
redundant when FULL is specified.

So this is literally the same. rewrite_heap_tuple does the job.

> Thanks for the detective work! I pushed this test change.

Thank you, I appreciate this.

--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-07-06 07:58:30 small doc fix - using expressions in plpgsql FETCH command
Previous Message Brahmam Eswar 2018-07-06 07:49:44 How to remove elements from array .

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2018-07-06 11:35:03 pgsql: Print DEBUG2 like that rather than as DEBUG
Previous Message Jeff Davis 2018-07-06 02:20:31 pgsql: Add test for partitionwise join involving default partition.