parseCheckAggregates vs. assign_query_collations

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: pgsql-hackers(at)postgresql(dot)org
Subject: parseCheckAggregates vs. assign_query_collations
Date: 2019-01-16 17:02:07
Message-ID: 87muo0k0c7.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Looking into a bug report on the -general list about grouping sets,
which turns out to be an issue of collation assignment: if the query has

CASE GROUPING(expr) WHEN 1 ...

then the expression is rejected as not matching the one in the GROUP BY
clause, because CASE already assigned collations to the expression (as a
special case in its transform function) while the rest of the query
hasn't yet had them assigned, because parseCheckAggregates gets run
before assign_query_collations.

I'll be looking into this in detail later, but right now, cam anyone
think of any reason why parseCheckAggregates couldn't be moved to after
assign_query_collations?

--
Andrew (irc:RhodiumToad)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-01-16 17:02:35 Re: [HACKERS] generated columns
Previous Message Andreas Karlsson 2019-01-16 16:56:15 Re: [HACKERS] REINDEX CONCURRENTLY 2.0