| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file |
| Date: | 2020-02-25 23:55:06 |
| Message-ID: | 87mu96w7c5.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> A few lines further down from this we report an error in case we are unable to
> parse the file in question:
>
> pg_fatal("could not parse PG_VERSION file from %s\n", cluster->pgdata);
>
> Should the pgdata argument be quoted there as well, like \"%s\", to make it
> consistent for how we report filenames and directories in pg_upgrade?
Good point, I agree we should. Updated patch attached.
- ilmari
--
"A disappointingly low fraction of the human race is,
at any given time, on fire." - Stig Sandbeck Mathisen
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_upgrade-add-m-to-version-file-open-failure-mes.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-02-26 00:08:04 | Re: Resolving the python 2 -> python 3 mess |
| Previous Message | Daniel Gustafsson | 2020-02-25 23:31:26 | Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file |