| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: perlcritic: prohibit map and grep in void conext |
| Date: | 2021-08-27 10:32:30 |
| Message-ID: | 87mtp3uqip.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Jul 28, 2021 at 01:26:23PM +0200, Daniel Gustafsson wrote:
>> I'm fine with increasing this policy, but I don't have strong feelings. If we
>> feel the perlcritic policy change is too much, I would still prefer to go ahead
>> with the map rewrite part of the patch though.
>
> I have no issue either about the rewrite part of the patch, so I'd
> tend to just do this part and move on. Daniel, would you like to
> apply that?
Why the resistance to the perlcritic part? That one case is the only
violation in the tree today, and it's a pattern we don't want to let
back in (I will surely object every time I see it when reviewing
patches), so why not automate it?
- ilmari
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Fearing | 2021-08-27 10:37:59 | Re: create table like: ACCESS METHOD |
| Previous Message | Craig Ringer | 2021-08-27 09:41:40 | Re: Mark all GUC variable as PGDLLIMPORT |