From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im>, o(dot)tselebrovskiy(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru> |
Subject: | Re: Error in calculating length of encoded base64 string |
Date: | 2023-06-09 10:26:38 |
Message-ID: | 87mt19rkwx.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
>> On Thu, Jun 8, 2023 at 7:35 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> This bug is very ancient, dating to commit 79d78bb26 which
>>> added encode.c. (The other instances were presumably copied
>>> from there.) Still, it doesn't quite seem worth back-patching.
>
>> Is it worth investing time in trying to unify these 3 occurrences of
>> base64 length (and possibly other relevant) code to one place? If yes,
>> I can volunteer for it.
>
> I wondered about that too. It seems really silly that we made
> a copy in src/common and did not replace the others with calls
> to that.
Also, while we're at it, how about some unit tests that both encode and
calculate the encoded length of strings of various lengths and check
that they match?
- ilmari
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2023-06-09 10:44:46 | Re: index prefetching |
Previous Message | Tomas Vondra | 2023-06-09 10:18:11 | Re: index prefetching |