Re: SCMS question

From: Florian Weimer <fw(at)deneb(dot)enyo(dot)de>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Warren Turkal <wt(at)penguintechs(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: SCMS question
Date: 2007-02-23 23:35:56
Message-ID: 87lkioxx9f.fsf@mid.deneb.enyo.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Bruce Momjian:

>> The fact that you're still thinking in "patch application" means you're
>> still stuck in the CVS worldview. To "apply a patch" in a distributed
>> SCM(*) really means to merge a branch into the main development branch.
>> Of course, you can still see the entire "diff -c" if you want.
>
> How do I modify the patch before application if it comes from a branch?

You refuse to merge until you reach a point which is acceptable. One
large project even gets so far as to ask the submitter to clean up
history before merging it, so that all that polishing is gone and does
not show up after the merge. In the official tree, there's just a
clean sequence of incremental patches.

I'm not really sure if this is the right model for every project.
Personally, I'm a fan of the write-after-approval approach: per ACL,
everybody has got full write access, but most developers might only
apply their patches after some review and a formal go-ahead. This has
the advantage that everyone can fix obvious mistakes or back out wrong
patches if necessary, and it nicely distributes the integration
overhead.

But obviously, there are fairly successful projects which use very
different models, and switching just because the technology is there
to do things differently doesn't make much sense. But once you run
into problems like tagging a release taking hours, you should really
contemplate a move to Subversion. 8-P

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Lukas Kahwe Smith 2007-02-23 23:39:42 Re: Simple Column reordering
Previous Message Bruce Momjian 2007-02-23 23:32:07 Re: 5 Weeks till feature freeze or (do you know where your patch is?)