Re: Text <-> C string

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Volkan YAZICI" <yazicivo(at)ttmail(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Text <-> C string
Date: 2008-03-20 08:52:24
Message-ID: 87lk4d7p6f.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Volkan YAZICI <yazicivo(at)ttmail(dot)com> writes:
>> But I'd vote for TextPGetCString style Tom suggested for the eye-habit
>> compatibility with the rest of the code.
>
> If there are not additional votes, I'll go with TextPGetCString
> and CStringGetTextP.

I would have voted for text_to_cstring etc. I can see the logic for the above
but it's just such a pain to type...

Fwiw I didn't actually find text_cstring confusing because all our sql cast
functions are defined that way.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's Slony Replication support!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2008-03-20 09:11:45 Re: MemoryContextSwitchTo() confusion
Previous Message Martin Pihlak 2008-03-20 08:17:10 Re: stored procedure stats in collector

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-03-20 12:36:51 Re: Text <-> C string
Previous Message Martin Pihlak 2008-03-20 08:17:10 Re: stored procedure stats in collector