| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, evgeni-klimov(at)yandex(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #15096: Unable to CREATE TABLE LIKE with bigint identity column |
| Date: | 2018-03-05 00:16:03 |
| Message-ID: | 87lgf7l6sj.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
>>>>> "Michael" == Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Sat, Mar 03, 2018 at 07:55:41PM +0000, Andrew Gierth wrote:
>> sequence_options thinks it can put all the sequence parameters
>> through makeInteger and have them come out intact.
Michael> Yeah, on 32b machines "long" is 4 bytes...
And on 64-bit Windows, too.
Michael> Perhaps it would be the occasion to introduce a T_Integer64
Michael> type for Value which gets stored as a string? And as far as I
Michael> can see defGetInt64 is only used by sequences.
The slightly misnamed T_Float is what's currently used for Value nodes
which contain numeric values as strings. So there'd be no point in a new
type tag if you're still going to store the value as a string.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-05 05:44:32 | Re: BUG #15096: Unable to CREATE TABLE LIKE with bigint identity column |
| Previous Message | Michael Paquier | 2018-03-04 23:56:54 | Re: BUG #15096: Unable to CREATE TABLE LIKE with bigint identity column |