| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Luc Vlaming <luc(at)swarm64(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: "could not find pathkey item to sort" for TPC-DS queries 94-96 |
| Date: | 2021-04-20 10:01:28 |
| Message-ID: | 87lf9dnukn.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> + /* We ignore binary-compatible relabeling on both ends */
> + while (expr && IsA(expr, RelabelType))
> + expr = ((RelabelType *) expr)->arg;
There are 10 instances of this exact loop scattered around the codebase.
Is it worth it turning it into a static inline function?
- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-04-20 10:06:17 | Re: Tiny update to pg_stat_statements documentation |
| Previous Message | Amit Kapila | 2021-04-20 09:59:16 | Re: Replication slot stats misgivings |