From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Assorted typo fixes |
Date: | 2023-12-27 21:51:26 |
Message-ID: | 87le9fmi01.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi folks,
I was playing around with the `typos` tool
(https://github.com/crate-ci/typos) and thought I'd run it on the
posgres repo for fun. After a bit of tweaking to get rid of most false
positives (see separately attached .typos.toml file), it came up with a
useful set of suggestions, some of which I applied verbatim, others
which needed a bit more rewording.
Attached is a series of patches. The first one are what I consider
obvious, unambiguous fixes to code comments. The subsequent ones are
fixes for actual code (variable, function, type names) and docs, one
patch per class of typo. As far as I can tell, none of the code changes
(except the ECPG one, see below) affect anything exported, so this
should not cause any compatibility issues for extensions.
The ECPG change affects the generated C code, but from my reading of the
callers in descriptor.c and ecpg.trailer, any code that would have
caused it to encounter the affected enum value would fail to compile, so
either the case is not possible, or nobody actually uses whatever syntax
is affected (I don't know enough about ECPG to tell without spending far
too much time digging in the code).
- ilmari
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-typos-in-comments.patch | text/x-diff | 26.3 KB |
0002-tsquery-fix-typo-rewrited-rewritten.patch | text/x-diff | 2.7 KB |
0003-gist-fix-typo-split-t-ed-split.patch | text/x-diff | 8.5 KB |
0004-libpq-fix-typo-occurences-occurrences-in-tests.patch | text/x-diff | 3.4 KB |
0005-jsonpath_exec-fix-typo-absense-absence.patch | text/x-diff | 2.0 KB |
0006-jsonpath_gram-fix-typo-indexs-indices.patch | text/x-diff | 1.1 KB |
0007-pg_archivecleanup-fix-typo-extention-extension-in-he.patch | text/x-diff | 1.2 KB |
0008-ecpg-fix-typo-in-get_dtype-return-value-for-ECPGd_co.patch | text/x-diff | 950 bytes |
0009-ci-fix-typo-in-macports-check-superfluos-superfluous.patch | text/x-diff | 869 bytes |
0010-doc-fix-typo-vertexes-vertices.patch | text/x-diff | 975 bytes |
0011-Write-c-cedilla-properly-in-check_decls.m4.patch | text/x-diff | 824 bytes |
0012-doc-fix-typo-formattings-in-rangedypes-docs.patch | text/x-diff | 1.1 KB |
.typos.toml | application/toml | 2.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2023-12-27 21:52:15 | Re: [HACKERS] Changing references of password encryption to hashing |
Previous Message | Jonathan S. Katz | 2023-12-27 21:31:21 | Re: Password leakage avoidance |