Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> On Wed, Feb 26, 2020 at 10:06:38AM +0100, Magnus Hagander wrote:
>>> +1, seems like that would be a regression in value.
>
>> Having more generic messages is less work for translators, we have
>> PG_VERSION in the file name, and that's more complicated to translate
>> in both French and Japanese. No idea about other languages.
>
> Just looking at the committed diff, it seems painfully obvious that these
> two messages were written by different people who weren't talking to each
> other. Why aren't they more alike? Given
>
> pg_fatal("could not open version file \"%s\": %m\n", ver_filename);
>
> (which seems fine to me), I think the second ought to be
>
> pg_fatal("could not parse version file \"%s\"\n", ver_filename);

Good point. Patch attached.

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl