Re: logical copy_replication_slot issues

From: Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: logical copy_replication_slot issues
Date: 2020-03-04 15:36:44
Message-ID: 87k1406sj7.fsf@ars-thinkpad
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> writes:

> I've attached the updated version patch that incorporated your
> comments. I believe we're going in the right direction for fixing this
> bug. I'll register this item to the next commit fest so as not to
> forget.

I've moved confirmed_flush check to the second lookup out of paranoic
considerations (e.g. slot could have been recreated and creation hasn't
finished yet) and made some minor stylistic adjustments. It looks good
to me now.

Attachment Content-Type Size
fix_copy_slot_v3.patch text/x-diff 4.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2020-03-04 15:39:57 Re: [Proposal] Global temporary tables
Previous Message Tom Lane 2020-03-04 15:35:16 Re: Symbolic names for the values of typalign and typstorage