| From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, zoulx1982(at)163(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16931: source code problem about commit_ts |
| Date: | 2025-07-03 13:33:27 |
| Message-ID: | 87jz4p9z6g.fsf@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>>>
>>> Thanks for the ping! Pushed!
>> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
>> remove struct xl_commit_ts_set?
>
> You're right. I seem to have overlooked that.
>
>> After it, there is no reference to
>> xl_commit_ts_set. So Is it better clean them as well?
>
> Agreed, the patch looks good to me. Unless there are objections,
> I'll go ahead and commit it.
Thank you Fujii!
> While this could be considered an oversight in the original commit,
> it's not a bug fix, so I plan to apply it only to the master branch.
That makes sense to me.
--
Best Regards
Andy Fan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ZhangChi | 2025-07-03 13:45:20 | Re: BUG #18976: -0.0 with float8 will be transformed to 0 inpreparestatement but not in normal execution |
| Previous Message | Laurenz Albe | 2025-07-03 13:27:05 | Re: BUG #18976: -0.0 with float8 will be transformed to 0 inprepare statement but not in normal execution |