| From: | "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] Cover get_json_table_plan() with tests |
| Date: | 2026-07-27 13:06:34 |
| Message-ID: | 87jyqg7fad.fsf@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Aleksander Alekseev <aleksander(at)tigerdata(dot)com> writes:
Hello!
> Hi,
>
>> So what I actually need to do is *remove* part which executes `if
>> (IsA(plan, JsonTablePathScan))` branch since now it is executed
>> without the patch. I will submit an updated version.
>
> Here is the simplified patch.
I've reviewed the new version and now the coverage with this version is
92%, the version 2 was 95%, probably this is because the test doesn't
cover the "UNION" case.
I still wonder why you don't want to cover the 100% if it's just a small
changes in the test, but for now, this does third version it does
increase the coverage by 42%.
Regards!
--
Jonathan Gonzalez V.
EDB
https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-07-27 13:09:20 | [PATCH] SAOP nullability analysis below NOT/BooleanTest |
| Previous Message | David Rowley | 2026-07-27 12:46:18 | Re: bug: query returns different result with and without memoization. |