| From: | Andreas Seltenreich <andreas(dot)seltenreich(at)credativ(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Bernd Helmle <bernd(at)oopsware(dot)de> |
| Subject: | Re: 9.3.9 and pg_multixact corruption |
| Date: | 2015-09-25 07:41:43 |
| Message-ID: | 87eghndjyg.fsf@credativ.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera writes:
> Jim Nasby wrote:
>> Do we officially not support anything > -O2? If so it'd be nice if configure
>> threw at least a warning (if not an error that you had to explicitly
>> over-ride).
>
> Keep in mind this is Sun OS C -- not one of the most popular compilers
> in the world. I don't know what you suggest: have a test program that
> configure runs and detects whether the compiler does the wrong thing?
> It doesn't seem a sane idea to maintain test cases for all known
> compiler bugs ...
I think the intention was to make configure complain if there's a -O > 2
in CFLAGS.
OTOH, a unit test for multixact.c that exercises the code including
wraparounds sounds like a desirable thing regardless of the fact that it
could have caught this miscompilation earlier than 6 months into
production.
regards,
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Torsten Zuehlsdorff | 2015-09-25 07:57:24 | Re: No Issue Tracker - Say it Ain't So! |
| Previous Message | Andreas Seltenreich | 2015-09-25 07:37:39 | Re: 9.3.9 and pg_multixact corruption |