| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Mark Dilger <hornschnorter(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Hash support for grouping sets |
| Date: | 2017-03-24 23:39:30 |
| Message-ID: | 87efxm8cxp.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:
>> I could move most of the block comment for ExecInitAgg up into the
>> file header; would that be better?
Andres> Yes, I think so.
Done that and some other clarifications. Attached is the latest patch;
no substantive changes, only comments, formatting and a change to a
variable name.
The performance side of things I'm still working on; I think that would
be best handled as a followup patch.
--
Andrew (irc:RhodiumToad)
| Attachment | Content-Type | Size |
|---|---|---|
| gshash26.patch | text/x-patch | 152.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2017-03-24 23:57:38 | Fetch JSONB Value for UNIQUE Constraint |
| Previous Message | Alvaro Herrera | 2017-03-24 23:35:07 | Re: dsm.c API tweak |