Re: [GSoC] create type questions

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Charles Cui <charles(dot)cui1984(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GSoC] create type questions
Date: 2018-06-02 17:44:12
Message-ID: 87efhpxezz.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Charles" == Charles Cui <charles(dot)cui1984(at)gmail(dot)com> writes:

Charles> Hi Tom,
Charles> Thanks for your comments, I do forget create type shell.
Charles> But even if I add this line still does not work.
Charles> Here is the commit that can demo my bug (
Charles> https://github.com/charles-cui/pg_thrift/commit/8b43f3e2172f4a1b4e61211f7d76b061a90c38f7
Charles> )
Charles> To see it, download the repo and do make install && make installcheck.
Charles> It cannot return a bytea as expected.

Your output function isn't doing anything, and in particular it's not
returning any value (just dropping off the end), so as soon as pg tries
to output a query result containing a thrift_binary value, it either
outputs garbage or crashes.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Charles Cui 2018-06-02 18:41:29 Re: [GSoC] create type questions
Previous Message Tom Lane 2018-06-02 17:24:41 Re: pg_config.h.win32 missing a set of flags from pg_config.h.in added in v11 development