Re: Possible bug: SQL function parameter in window frame definition

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alastair McKinley <a(dot)mckinley(at)analyticsengines(dot)com>, "pgsql-general\(at)lists(dot)postgresql(dot)org" <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: Possible bug: SQL function parameter in window frame definition
Date: 2019-09-29 10:46:49
Message-ID: 87eezzmls2.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

>>>>> "Andrew" == Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:

Andrew> We could minimize the chance of breakage in a back-patched fix
Andrew> by having query_tree_walker/mutator iterate the windowClause
Andrew> list itself

Here is a draft patch along those lines; the intent of this one is that
no existing walker or mutator should need to change (the change to the
dependency code is basically cosmetic I believe, just avoids walking
some things twice).

Also added some tests.

--
Andrew (irc:RhodiumToad)

Attachment Content-Type Size
wc2.patch text/x-patch 6.5 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2019-09-29 18:15:31 Re: Possible bug: SQL function parameter in window frame definition
Previous Message Vik Fearing 2019-09-29 08:50:32 Re: How to handle things that change over time?

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2019-09-29 14:29:56 Re: pgsql: Implement jsonpath .datetime() method
Previous Message chenhj 2019-09-29 08:16:28 Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7)