Re: add function for creating/attaching hash table in DSM registry

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: add function for creating/attaching hash table in DSM registry
Date: 2025-06-05 11:22:58
Message-ID: 87ecvywhyl.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:

> +typedef struct NamedDSMHashState
> +{
> + dsa_handle dsah;
> + dshash_table_handle dshh;
> + int dsa_tranche;
> + char dsa_tranche_name[68]; /* name + "_dsa" */
> + int dsh_tranche;
> + char dsh_tranche_name[68]; /* name + "_dsh" */
> +} NamedDSMHashState;

I don't have enough knowledge to review the rest of the patch, but
shouldn't this use NAMEDATALEN, rather than hard-coding the default
length?

- ilmari

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2025-06-05 11:33:42 Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them
Previous Message Peter Eisentraut 2025-06-05 11:14:48 Re: Possibly hard-to-read message