Re: What in the world is happening on spoonbill?

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgresql(dot)org>, "Stefan Kaltenbrunner" <stefan(at)kaltenbrunner(dot)cc>, "Michael Meskes" <meskes(at)postgresql(dot)org>
Subject: Re: What in the world is happening on spoonbill?
Date: 2008-05-18 04:56:33
Message-ID: 87d4nkjjlq.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Woulnd't it be enough to report the exist status if a test fails, instead of
>> requiring a certain exit status for success?
>
> What I have it doing is reporting the exit status if not zero, but it's
> only an annotation on the short-form output; it doesn't control whether
> the test is considered to have succeeded or not. I'm not very happy
> with that because a crash after all the expected output has been
> produced would not result in a report of failure --- and we have seen
> problems with psql crashing at exit, so this isn't an academic point.

It might be a bit weird but pg_regress could stick a message in the output
file before it does the comparison with the expected results.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-18 04:59:50 Re: Link requirements creep
Previous Message Greg Smith 2008-05-18 04:52:03 Re: Link requirements creep