| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org> |
| Subject: | copyParamList |
| Date: | 2016-05-27 22:07:43 |
| Message-ID: | 87d1o76u1u.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
copyParamList does not respect from->paramMask, in what looks to me like
an obvious oversight:
retval->paramMask = NULL;
[...]
/* Ignore parameters we don't need, to save cycles and space. */
if (retval->paramMask != NULL &&
!bms_is_member(i, retval->paramMask))
retval->paramMask is never set to anything not NULL in this function,
so surely that should either be initializing it to from->paramMask, or
checking from->paramMask in the conditional?
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-05-27 22:30:08 | Re: [sqlsmith] PANIC: failed to add BRIN tuple |
| Previous Message | Andres Freund | 2016-05-27 21:56:57 | Re: 9.4 -> 9.5 regression with queries through pgbouncer on RHEL 6 |