Re: Possible bug: SQL function parameter in window frame definition

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alastair McKinley <a(dot)mckinley(at)analyticsengines(dot)com>, "pgsql-general\(at)lists(dot)postgresql(dot)org" <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: Possible bug: SQL function parameter in window frame definition
Date: 2019-09-30 05:37:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

>> Here is a draft patch along those lines; the intent of this one is
>> that no existing walker or mutator should need to change (the change
>> to the dependency code is basically cosmetic I believe, just avoids
>> walking some things twice).

Tom> Hmm. I think this is a reasonable direction to go in, but
Tom> what about groupingSets and rowMarks?

groupingSets ultimately contains nothing but numbers which are
meaningless without reference to the matching groupClause list. So
anything that cares about those is really going to have to process them
in its Query case in the walker function in order to get at both

Similarly, rowMarks contains indexes into the rangetable (and no
recursive substructure at all), so it's likewise better processed at the
Query level.

Tom> Also, in HEAD I'd be inclined to add assertions about utilityStmt
Tom> being NULL.


Andrew (irc:RhodiumToad)

In response to


Browse pgsql-general by date

  From Date Subject
Next Message Gerrit Fouche 2019-09-30 09:15:47 pg_upgrade (Checking for reg* data types)
Previous Message Ben Chobot 2019-09-30 03:52:10 Re: Redis 16 times faster than Postgres?

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2019-09-30 05:38:10 Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7)
Previous Message Michael Paquier 2019-09-30 05:35:22 Re: SSL tests failing for channel_binding with OpenSSL <= 1.0.1