Re: FETCH FIRST clause WITH TIES option

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Surafel Temesgen <surafel3000(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FETCH FIRST clause WITH TIES option
Date: 2020-04-08 02:01:33
Message-ID: 87a73mn4cl.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Alvaro" == Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:

Alvaro> It turns out that the SQL standard is much more limited in what
Alvaro> it will accept there. But our grammar (what we'll accept for
Alvaro> the ancient LIMIT clause) is very lenient -- it'll take just
Alvaro> any expression. I thought about reducing that to NumericOnly
Alvaro> for FETCH FIRST .. WITH TIES, but then I have to pick: 1)
Alvaro> gram.y fails to compile because of a reduce/reduce conflict, or
Alvaro> 2) also restricting FETCH FIRST .. ONLY to NumericOnly. Neither
Alvaro> of those seemed very palatable.

FETCH FIRST ... ONLY was made _too_ restrictive initially, such that it
didn't allow parameters (which are allowed by the spec); see 1da162e1f.

(That change didn't present a problem for ruleutils, because FETCH FIRST
... ONLY is output as a LIMIT clause instead.)

This needs to be fixed in ruleutils, IMO, not by changing what the
grammar accepts.

--
Andrew.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-04-08 02:10:07 Re: pgsql: Allow users to limit storage reserved by replication slots
Previous Message Etsuro Fujita 2020-04-08 01:36:58 Re: [HACKERS] advanced partition matching algorithm for partition-wise join