Re: Review items for EXCEPT TABLE publication

> On Sep 10, 2026, at 13:39, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Finding #3: Missing check in test_except_root_partition
>
> In test_except_root_partition, the test assigns the result of:
> SELECT count(*) = 0 FROM pg_logical_slot_get_binary_changes(...)
> to $result under a comment saying that it verifies the table is not
> published, but there is no is() check. $result is then overwritten by
> the following loop, so the check has no effect.
>
> Added an is() check to verify the result of the query.
>
> Regards,
> Vignesh
> <v1-0001-Fix-ALTER-PUBLICATION-race-with-concurrent-SET-AL.patch><v1-0005-Prevent-unlogged-tables-in-publication-EXCEPT-cla.patch><v1-0003-Fix-missing-check-in-test_except_root_partition.patch><v1-0002-Fix-ALTER-PUBLICATION-validation-race.patch><v1-0004-Fix-test-to-use-a-fresh-subscription.patch>

v1-0003 looks good to me. The added is() correctly makes the previously ignored check effective. I also ran the test and it passed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/