| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Shinoda, Noriyoshi (PN Japan FSI)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tab complete for CREATE OR REPLACE TRIGGER statement |
| Date: | 2020-11-17 02:14:51 |
| Message-ID: | 879741.1605579291@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Nov 16, 2020 at 08:12:05AM +0000, Shinoda, Noriyoshi (PN Japan FSI) wrote:
>> Yesterday, OR REPLACE clause was provided to the CREATE TRIGGER
>> statement, so I wrote a patch for tab completion for the psql
>> command.
> Thanks, the logic looks fine. I'll apply if there are no objections.
> Please note that git diff --check and that the indentation does not
> seem quite right, but that's easy enough to fix.
It's kind of depressing how repetitive the patch is. There's
probably not much to be done about that in the short run, but
it seems to point up the need to start thinking about how to
refactor tab-complete.c more thoroughly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Li Japin | 2020-11-17 02:45:12 | Re: Terminate the idle sessions |
| Previous Message | Michael Paquier | 2020-11-17 02:02:19 | Re: Tab complete for CREATE OR REPLACE TRIGGER statement |