From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: On /*----- comments |
Date: | 2023-07-04 18:36:43 |
Message-ID: | 879138.1688495803@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 03/07/2023 11:48, Daniel Gustafsson wrote:
> On 30 Jun 2023, at 17:22, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Seems reasonable; the trailing dashes eat a line without adding much.
>> +1
> Pushed a patch to remove the end-guard from the example in the pgindent
> README. And fixed the bogus end-guard in walsender.c.
I don't see any actual push?
> I'm not sure there is a universal best length. It depends on the comment
> what looks best. The very long ones in particular would not look good on
> comments in a deeply indented block. So I think the status quo is fine.
OK, no strong feeling about that here.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-07-04 18:37:36 | Re: O(n) tasks cause lengthy startups and checkpoints |
Previous Message | Tom Lane | 2023-07-04 18:33:14 | Re: Cleaning up array_in() |