Re: [sqlsmith] crash in RestoreLibraryState during low-memory testing

From: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [sqlsmith] crash in RestoreLibraryState during low-memory testing
Date: 2017-10-03 07:04:50
Message-ID: 878tgsu2y5.fsf@ansel.ydns.eu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane writes:

> Presumably somebody could dig into the libc source code and prove or
> disprove this, though it would sure help to know exactly what platform
> and version Andreas is testing on.

This is the code in glibc-2.24 around the crash site:

,----[ glibc-2.24/elf/dl-load.c:442 ]
| to_free = cp = expand_dynamic_string_token (l, cp, 1);
|
| size_t len = strlen (cp);
`----

…while expand_dynamic_string_token will indeed return NULL on a failed
malloc. Code in the most recent glibc looks the same, so I'll carry
this issue over to the glibc bugzilla then.

Sorry about the noise…
Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-10-03 07:18:11 Re: [PATCH] Improve geometric types
Previous Message Andres Freund 2017-10-03 06:55:02 Re: pnstrdup considered armed and dangerous