| From: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, sawada(dot)mshk(at)gmail(dot)com, a(dot)sher(at)postgrespro(dot)ru, k(dot)knizhnik(at)postgrespro(dot)ru, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Possible bug in logical replication. |
| Date: | 2018-05-25 06:57:18 |
| Message-ID: | 878t88ql2p.fsf@ars-thinkpad |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Maybe I am being too naive, but wouldn't it be just enough to update the
> confirmed flush LSN to ctx->reader->ReadRecPtr? This way, the slot
> advances up to the beginning of the last record where user wants to
> advance, and not the beginning of the next record:
Same problem should be handled at pg_logical_slot_get_changes_guts and
apply worker feedback; and there is a convention that all commits since
confirmed_flush must be decoded, so we risk decoding such boundary
commit twice.
--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-05-25 07:04:58 | Re: Fix some error handling for read() and errno |
| Previous Message | Andres Freund | 2018-05-25 06:50:48 | Re: Keeping temporary tables in shared buffers |