From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: wrong query result with jit_above_cost= 0 |
Date: | 2018-06-26 20:55:07 |
Message-ID: | 878t71p9c8.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>>> "Dmitry" == Dmitry Dolgov <9erthalion6(at)gmail(dot)com> writes:
Dmitry> Yep, my bad, forgot to turn it on. Now I see what's the
Dmitry> problem, one of the null fields is screwed up, will try to
Dmitry> figure out why is that.
The handling of nulls in grouping set results is a bit icky, see
prepare_projection_slot in nodeAgg.c. The comment there lists a number
of assumptions which may or may not hold true under JIT which might give
a starting point to look for problems. (Unfortunately I'm not currently
in a position to test on a JIT build)
(This wasn't my first choice of approach; originally I had a GroupedVar
node that evaluated either as the Var would or to NULL instead, and put
that into the projection. However there was a lot of resistance to this
approach at the time, and the new node idea was abandoned in favour of
poking directly into the slot.)
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-06-26 20:56:43 | Re: wrong query result with jit_above_cost= 0 |
Previous Message | Robbie Harwood | 2018-06-26 20:54:13 | Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints |