Re: Ryu floating point output patch

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Donald Dong <xdong(at)csumb(dot)edu>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>
Subject: Re: Ryu floating point output patch
Date: 2019-02-03 11:04:37
Message-ID: 878syx6t9w.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Some final (I hope) updates:

- adopt Noah's configure code for -Wno-declaration-after-statement
- remove some code that proved to be dead, replaced by comments and
asserts
- add header comments for the public entry points
- move definition of buffer lengths to public header and comment them
- comment some assumptions that might otherwise be overlooked
- simplify some of the fixed-point optimizations slightly
- clarify some comments
- change _buf variants to return the string length, just because they can

--
Andrew (irc:RhodiumToad)

Attachment Content-Type Size
ryu11.patch text/x-patch 309.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2019-02-03 11:16:59 Re: Early WIP/PoC for inlining CTEs
Previous Message Andres Freund 2019-02-03 11:00:11 Re: pg_upgrade: Pass -j down to vacuumdb