Re: Mostly Harmless: Welcoming our C++ friends

Greg Smith <gsmith(at)gregsmith(dot)com> writes:

> You can just ignore this late night bit of idiocy, or mock me for it as you see
> fit. Note to other reviewers: if your e-mail client is the sort that bunches
> a series of text attachments all together, make sure to scroll completely past
> the first patch in the diff before you pay attention to the rest of it. I'm
> going to bed.

Your email client is doing the right thing. The attachments had the following
header on them which controls this:

Content-Disposition: inline;

I wonder how many email clients let the poster control this header though :(
If you post with content-disposition set to "attachment" instead of "inline"
it should appear as a separate file you can save.

Regarding the patches, we could apply the trivial stuff right around the time
of the pgindent run, after all the major patches are drained from the queue so
it doesn't cause extra conflicts. It would still cause any other pending
patches for 8.5 to bitrot but from the sounds of things shouldn't be too hard
to fix up.

It seems to me we ought to do this regardless of whether we apply the
functional changes.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's On-Demand Production Tuning