Re: Should contrib modules install .h files?

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should contrib modules install .h files?
Date: 2018-08-01 03:52:28
Message-ID: 87600ubvb7.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

>> If your extension is relying on pg11+, or you have checked the pg
>> version when constructing the makefile, you can just do:
>> PG_CPPFLAGS += -I$(includedir_server)/extension/hstore
>> and #include "hstore.h" will work.

Tom> I remain of the opinion that it'd be smarter to do

Tom> PG_CPPFLAGS += -I$(includedir_server)/extension

Tom> then

Tom> #include "hstore/hstore.h"

Tom> This way requires fewer -I options and is far more robust against
Tom> header name conflicts.

Sure, it works for the simple cases like hstore, but how does it handle
the case of a pgxs extension that installs more than one include file,
one of which includes another?

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-08-01 03:55:15 Re: Should contrib modules install .h files?
Previous Message Bruce Momjian 2018-08-01 02:55:52 Re: pg_upgrade from 9.4 to 10.4