Re: Server-side base backup: why superuser, not pg_write_server_files?

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Server-side base backup: why superuser, not pg_write_server_files?
Date: 2022-01-28 17:15:59
Message-ID: 875yq3233k.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> writes:

> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>
>> On Fri, Jan 28, 2022 at 5:58 AM Dagfinn Ilmari Mannsåker
>> <ilmari(at)ilmari(dot)org> wrote:
>>> I just noticed that the new server-side base backup feature requires
>>> superuser privileges (which is only documented in the pg_basebackup
>>> manual, not in the streaming replication protocol specification).
>>>
>>> Isn't this the kind of thing the pg_write_server_files role was created
>>> for, so that it can be delegated to a non-superuser?
>>
>> That's a good idea. I didn't think of that. Would you like to propose a patch?
>
> Sure, I'll try and whip something up over the weekend.

Or now. Patch attached.

- ilmari

Attachment Content-Type Size
0001-Allow-BASE_BACKUP-TARGET-server-to-pg_write_server_f.patch text/x-diff 2.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-01-28 17:33:24 Re: Server-side base backup: why superuser, not pg_write_server_files?
Previous Message Dmitry Dolgov 2022-01-28 16:51:56 Re: Multiple Query IDs for a rewritten parse tree